feat: Add createdAt key to json in registry
#532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HazAT
changed the title
created key to json in registrycreatedAt key to json in registry
Lms24
reviewed
Apr 11, 2024
src/targets/registry.ts
Outdated
Comment on lines
365
to
369
| const updatedManifest: { [key: string]: any } = { | ||
| ...packageManifest, | ||
| version, | ||
| }; | ||
| updatedManifest.createdAt = new Date().toISOString(); |
There was a problem hiding this comment.
Just to confirm: the manifest is what ends up here, correct? If yes, then I think adding a new field should be safe
Lms24
approved these changes
Apr 11, 2024
| } = { | ||
| ...packageManifest, | ||
| version, | ||
| createdAt: new Date().toISOString(), |
There was a problem hiding this comment.
is there a plan to backfill this data?
any test that needs updating?
There was a problem hiding this comment.
Added a simple unit test to check if property is there
here is the PR to backfill the data for existing files
getsentry/sentry-release-registry#148
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to use the data from our release registry more, one info that is missing today is the timestamp of when something was released.
Yes, in theory, it exists in git, but just for convenience, we want to add a key
createdAtinto every JSON that the Registry target writes for easier access later.